Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1418523: Minor refactor for resolve_imports_and_packages #2311

Merged
merged 1 commit into from
Sep 18, 2024
Merged

SNOW-1418523: Minor refactor for resolve_imports_and_packages #2311

merged 1 commit into from
Sep 18, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1418523

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    We make a minor refactor in function resolve_imports_and_packages to make it more readable

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 17, 2024
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review September 17, 2024 21:36
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner September 17, 2024 21:36
@sfc-gh-aalam sfc-gh-aalam merged commit 6b8df76 into main Sep 18, 2024
34 of 35 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1418523-refactor-resolve_imports_and_packages branch September 18, 2024 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aalam @sfc-gh-jdu @sfc-gh-jrose