SNOW-1669082: Add support for Resampler.asfreq
#2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-joshi
approved these changes
Sep 18, 2024
Co-authored-by: Jonathan Shi <[email protected]>
| @@ -56,3 +69,5 @@ def test_asfreq_negative(): | |||
| snow_df.asfreq(freq="5s", method="ffill", normalize=True) | |||
| with pytest.raises(NotImplementedError): | |||
| snow_df.asfreq(freq="5s", method="ffill", fill_value=2) | |||
There was a problem hiding this comment.
Why are we testing DataFrame.asfreq here when the test file is test_resample_asfreq?
There was a problem hiding this comment.
DataFrame/Series.asfreq ends up just calling the resample implementation with the first aggregation. I didn't realize at that time the Resampler class also has an asfreq so this PR just adds that. That's why all 3 are tested in the same file under the resample folder.
sfc-gh-helmeleegy
approved these changes
Sep 18, 2024
Signed-off-by: Naren Krishna <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1669082
This PR implements
Resampler.asfreqwhich follows the same underlying code path asSeries.asfreqandDataFrame.asfreqwhich was implemented in a previous PR.