-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-1320248]: Fix inplace=True
on Series objects derived from Series.
#2307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Rehan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please resolve other comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if this is a bug in OSS Modin, and file an issue there if so?
Co-authored-by: Hazem Elmeleegy <[email protected]>
I was able to confirm that the bug is not reproducible on OSS Modin on Ray in the latest version installable from pip, so I think this is a snowpark only issue! In [1]: import modin.pandas as pd
d
In [2]: df = pd.read_csv("/Users/rdurrani/Downloads/test.csv")
2024-09-17 13:17:51,513 INFO worker.py:1749 -- Started a local Ray instance.
In [3]: s = df['Fare'].copy().iloc[:4]
...: s.fillna(14, inplace=True)
In [4]: s
Out[4]:
0 7.8292
1 7.0000
2 9.6875
3 8.6625
Name: Fare, dtype: float64 |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1320248
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR fixes the inplace argument for Series functions where the Series is derived from another Series object (e.g. series = series.iloc[:4]; series.fillna(14, inplace=True))