Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1320309: Remove unnecessary warning from sort_values #2306

Merged
merged 2 commits into from
Sep 19, 2024
Merged

SNOW-1320309: Remove unnecessary warning from sort_values #2306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
614e8c8
SNOW-1320309: Remove unnecessoary warning from sort_values
sfc-gh-nkumar Sep 17, 2024
f7c96ee
Update src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_c…
sfc-gh-nkumar Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Improved `to_pandas` to persist the original timezone offset for TIMESTAMP_TZ type.
- Improved `dtype` results for TIMESTAMP_TZ type to show correct timezone offset.
- Improved error message when passing non-bool value to `numeric_only` for groupby aggregations.
- Removed unnecessary warning about sort algorithm in `sort_values`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems so minor, is it even worth calling out as an improvement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it is pretty minor. But it does have user facing impact (right now this warning shows up in notebook in red) so might be good include this here.


#### New Features

Expand Down
5 changes: 3 additions & 2 deletions src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3355,9 +3355,10 @@ def sort_rows_by_column_values(
# This error message is different from native pandas hence, hence it is kept here instead
# of moving this to frontend layer.
raise ValueError(f"sort kind must be 'stable' or None (got '{kind}')")
if kind != "stable":
# Do not show warning for 'quicksort' as this the default option.
if kind not in ("stable", "quicksort"):
logging.warning(
f"choice of sort algorithm '{kind}' is ignored. sort kind must be 'stable' or None"
f"choice of sort algorithm '{kind}' is ignored. sort kind must be 'stable', 'quicksort', or None"
)

matched_identifiers = (
Expand Down
Loading