SNOW-1650875: Remove modin/pandas/io.py #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-joshi
added
NO-CHANGELOG-UPDATES
sfc-gh-joshi
force-pushed
the
joshi/move-io
branch
from
e4edc37 to
850f2b8
Compare
sfc-gh-joshi
force-pushed
the
joshi/move-io
branch
from
7cbcd51 to
24245fd
Compare
sfc-gh-azhan
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1650875
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Much of our logic for I/O operation dispatch, especially unimplemented operations, is shared with upstream Modin. This PR removes a lot of duplicated code to that effect.
Modin determines its execution engine based on the
Engineconfiguration variable, and will dynamically look for a class namedPandasOn${ENGINE}Factory. Within this PR, we setPandasOnSnowflakeFactoryas a Modin attribute so it can be discovered and used appropriately.