Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1665707: Move general.py into src/…/modin/plugin/extensions/ #2296

Merged
merged 15 commits into from
Sep 18, 2024
Merged

SNOW-1665707: Move general.py into src/…/modin/plugin/extensions/ #2296

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
32e81b7
SNOW-1665707: Move general.py into src/…/modin/plugin/extensions/
sfc-gh-helmeleegy Sep 16, 2024
9afd17f
fix errors
sfc-gh-helmeleegy Sep 16, 2024
8f253db
rename to general_overrides
sfc-gh-helmeleegy Sep 16, 2024
2fdeb1f
fix errors
sfc-gh-helmeleegy Sep 16, 2024
97a4740
fix errors
sfc-gh-helmeleegy Sep 16, 2024
df5f4d3
fix errors
sfc-gh-helmeleegy Sep 16, 2024
84579ca
fix errors
sfc-gh-helmeleegy Sep 16, 2024
b3662a0
fix errors
sfc-gh-helmeleegy Sep 17, 2024
0c14db2
fix errors
sfc-gh-helmeleegy Sep 17, 2024
821cd2a
fix errors
sfc-gh-helmeleegy Sep 17, 2024
2af5b23
fix errors
sfc-gh-helmeleegy Sep 17, 2024
2405ff2
fix errors
sfc-gh-helmeleegy Sep 17, 2024
51b6e61
Merge branch 'main' into helmeleegy-SNOW-1665707
sfc-gh-helmeleegy Sep 17, 2024
5823ef6
address comments
sfc-gh-helmeleegy Sep 17, 2024
8c3dfd0
Merge branch 'main' into helmeleegy-SNOW-1665707
sfc-gh-helmeleegy Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/check_standalone_function_snowpark_pandas_telemetry_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def check_standalone_function_snowpark_pandas_telemetry_decorator(
telemetry_decorator_name="snowpark_pandas_telemetry_standalone_function_decorator",
)
check_standalone_function_snowpark_pandas_telemetry_decorator(
target_file="src/snowflake/snowpark/modin/pandas/general.py",
target_file="src/snowflake/snowpark/modin/plugin/extensions/general_overrides.py",
telemetry_decorator_name="snowpark_pandas_telemetry_standalone_function_decorator",
)
check_standalone_function_snowpark_pandas_telemetry_decorator(
Expand Down
2 changes: 1 addition & 1 deletion docs/source/modin/general_functions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
General functions
=============================

.. currentmodule:: snowflake.snowpark.modin.pandas.general
.. currentmodule:: snowflake.snowpark.modin.pandas
.. rubric:: :doc:`All supported general functions <supported/general_supported>`

.. rubric:: Data manipulations
Expand Down
18 changes: 13 additions & 5 deletions src/snowflake/snowpark/modin/pandas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
register_dataframe_accessor,
register_series_accessor,
)
from snowflake.snowpark.modin.pandas.general import (

from snowflake.snowpark.modin.plugin.extensions.general_overrides import ( # isort: skip # noqa: E402,F401
bdate_range,
concat,
crosstab,
Expand All @@ -121,7 +122,8 @@
value_counts,
wide_to_long,
)
from snowflake.snowpark.modin.pandas.io import ( # read_json is provided by overrides module
from snowflake.snowpark.modin.pandas.io import ( # isort: skip # noqa: E402,F401
# read_json is provided by overrides module
ExcelFile,
HDFStore,
json_normalize,
Expand All @@ -146,12 +148,17 @@
read_xml,
to_pickle,
)
from snowflake.snowpark.modin.plugin._internal.session import SnowpandasSessionHolder
from snowflake.snowpark.modin.plugin._internal.telemetry import (
from snowflake.snowpark.modin.plugin._internal.session import ( # isort: skip # noqa: E402,F401
SnowpandasSessionHolder,
)
from snowflake.snowpark.modin.plugin._internal.telemetry import ( # isort: skip # noqa: E402,F401
TELEMETRY_PRIVATE_METHODS,
try_add_telemetry_to_attribute,
)
from snowflake.snowpark.modin.plugin.utils.frontend_constants import _ATTRS_NO_LOOKUP
from snowflake.snowpark.modin.plugin.utils.frontend_constants import ( # isort: skip # noqa: E402,F401
_ATTRS_NO_LOOKUP,
)


# The extensions assigned to this module
_PD_EXTENSIONS_: dict = {}
Expand All @@ -171,6 +178,7 @@
import snowflake.snowpark.modin.plugin.extensions.base_overrides # isort: skip # noqa: E402,F401
import snowflake.snowpark.modin.plugin.extensions.dataframe_extensions # isort: skip # noqa: E402,F401
import snowflake.snowpark.modin.plugin.extensions.dataframe_overrides # isort: skip # noqa: E402,F401
import snowflake.snowpark.modin.plugin.extensions.general_overrides # isort: skip # noqa: E402,F401
sfc-gh-helmeleegy marked this conversation as resolved.
Show resolved Hide resolved
import snowflake.snowpark.modin.plugin.extensions.series_extensions # isort: skip # noqa: E402,F401
import snowflake.snowpark.modin.plugin.extensions.series_overrides # isort: skip # noqa: E402,F401

Expand Down
Loading
Loading