Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1657460 Improved results for TIMESTAMP_TZ type to show correct timezone offset. #2290

Merged
merged 4 commits into from
Sep 18, 2024
Merged

SNOW-1657460 Improved results for TIMESTAMP_TZ type to show correct timezone offset. #2290

merged 4 commits into from
Sep 18, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Sep 12, 2024 •
edited by sfc-gh-mvashishtha
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1657460

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Previously we use "datetime64[ns]" as the dtype for datetime with timezone which is missing the tz info. This change will extract the timezone from timestamp_tz column and show the timezone offset when calling dtypes.

@sfc-gh-azhan sfc-gh-azhan added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Sep 12, 2024
@sfc-gh-azhan sfc-gh-azhan force-pushed the azhan-tz-dtype-1657460 branch 5 times, most recently from 0d59f29 to 4b901bb Compare September 13, 2024 21:45
@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review September 13, 2024 21:45
@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner September 13, 2024 21:45
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title SNOW-1657460 Improved results for TIMESTAMP_TZ type to show correct … SNOW-1657460 Improved results for TIMESTAMP_TZ type to show correct timezone offset. Sep 16, 2024
sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Sep 16, 2024
View reviewed changes
tests/integ/modin/series/test_dt_accessor.py
snow_ser = pd.Series(native_ser)
# This is a great example to show the current limit of Snowpark pandas timezone, it only preserves the timezone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is great!

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andong!

sfc-gh-rdurrani
sfc-gh-rdurrani reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some questions/nits, but overall lgtm!

src/snowflake/snowpark/modin/pandas/indexing.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py Outdated Show resolved Hide resolved
tests/integ/modin/frame/test_dtypes.py Outdated Show resolved Hide resolved
tests/integ/modin/series/test_astype.py Outdated Show resolved Hide resolved
sfc-gh-rdurrani
sfc-gh-rdurrani approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@sfc-gh-azhan sfc-gh-azhan merged commit 20d9738 into main Sep 18, 2024
37 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-tz-dtype-1657460 branch September 18, 2024 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar

@sfc-gh-rdurrani sfc-gh-rdurrani Awaiting requested review from sfc-gh-rdurrani

@sfc-gh-nkrishna sfc-gh-nkrishna Awaiting requested review from sfc-gh-nkrishna

Assignees
No one assigned
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-azhan @sfc-gh-rdurrani @sfc-gh-nkrishna @sfc-gh-helmeleegy