SNOW-1418523: concurrent file operations #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection-thread-safe
…ad-safe' into aalam-SNOW-1418523-make-analyzer-server_connection-thread-safe
sfc-gh-aalam
requested review from
sfc-gh-yixie,
sfc-gh-aling and
sfc-gh-jrose
and removed request for
a team
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
8 tasks
…ad-safe' into aalam-SNOW-1418523-make-analyzer-server_connection-thread-safe
sfc-gh-aalam
requested review from
sfc-gh-jkew and
sfc-gh-lmukhopadhyay
and removed request for
a team
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aalam
force-pushed
the
aalam-SNOW-1418523-concurrent-file-operations
branch
from
fde612e to
df3263c
Compare
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aling
approved these changes
Sep 19, 2024
sfc-gh-yuwang
approved these changes
Sep 20, 2024
Base automatically changed from
aalam-SNOW-1418523-make-analyzer-server_connection-thread-safe
to
aalam-SNOW-1418523-make-internal-session-variables-thread-safe
September 25, 2024 16:50
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aalam
merged commit 0624824
into
aalam-SNOW-1418523-make-internal-session-variables-thread-safe
32 checks passed
sfc-gh-aalam
deleted the
aalam-SNOW-1418523-concurrent-file-operations
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1418523
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This change adds tests for ensuring fileIO works correctly in multithreading mode. Since file io relies on cursor, make cursor safe in SNOW-1418523 make analyzer server connection thread safe #2282 is sufficient to achieve this goal.