Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1662105, SNOW-1662657: Support by, left_by, right_by for pd.merge_asof #2284

Merged
merged 7 commits into from
Sep 13, 2024
Merged

SNOW-1662105, SNOW-1662657: Support by, left_by, right_by for pd.merge_asof #2284

merged 7 commits into from
Sep 13, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna commented Sep 12, 2024 •
edited
Loading

SNOW-1662105, SNOW-1662657

This PR refactors join_utils.py to make left_on and right_on optional arguments, as they are not required for "cross" or "asof" joins. It also support by, left_by, right_by for pd.merge_asof.

@sfc-gh-nkrishna sfc-gh-nkrishna requested a review from a team as a code owner September 12, 2024 15:50
@sfc-gh-nkrishna sfc-gh-nkrishna added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 12, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna requested review from sfc-gh-yzou and removed request for sfc-gh-lspiegelberg September 12, 2024 15:59
@sfc-gh-jjiao
Copy link
Contributor

@sfc-gh-nkrishna I created a JIRA ticket for this refactor work from you, could you please or do you mind I linking it to this PR? https://snowflakecomputing.atlassian.net/browse/SNOW-1662105 Thanks

@sfc-gh-nkrishna sfc-gh-nkrishna changed the title REFACTOR: Make left join identifiers and right join identifiers optional for join utility SNOW-1662105: Make left join identifiers and right join identifiers optional for join utility Sep 12, 2024
sfc-gh-vbudati
sfc-gh-vbudati approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-vbudati sfc-gh-vbudati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Naren!

@sfc-gh-helmeleegy
Copy link
Contributor

Perhaps @sfc-gh-nkumar can take a quick look?

@sfc-gh-nkrishna
address comments
9ccab00 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title SNOW-1662105: Make left join identifiers and right join identifiers optional for join utility SNOW-1662105: Support by, left_by, right_by for pd.merge_asof Sep 12, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna changed the title SNOW-1662105: Support by, left_by, right_by for pd.merge_asof SNOW-1662105, SNOW-1662657: Support by, left_by, right_by for pd.merge_asof Sep 12, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna removed NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 12, 2024
@sfc-gh-nkrishna
add comment
ad2a76d 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna
address comments
85d4aef 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna sfc-gh-nkrishna merged commit a3586c8 into main Sep 13, 2024
35 checks passed
@sfc-gh-nkrishna sfc-gh-nkrishna deleted the asof_join_refactor branch September 13, 2024 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-yzou sfc-gh-yzou sfc-gh-yzou left review comments

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-rdurrani sfc-gh-rdurrani Awaiting requested review from sfc-gh-rdurrani sfc-gh-rdurrani is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfc-gh-nkrishna @sfc-gh-jjiao @sfc-gh-helmeleegy @sfc-gh-azhan @sfc-gh-yzou @sfc-gh-vbudati