Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1632895] Add derive_dependent_columns_with_duplication capability #2272

Merged
merged 9 commits into from
Sep 16, 2024

Conversation

sfc-gh-yzou
Copy link
Collaborator

@sfc-gh-yzou sfc-gh-yzou commented Sep 11, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1632895

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

in order to handle nested select with column dependency (not handled by sql simplifier) complexity calculation, added a utility support for deriving all column depenencies with duplication, for example, col('a') + col('b') + 3*('a'), should return dependency ['a', 'b', 'a'] this provides both information about the columns it dependents on and also the number of times/

@sfc-gh-yzou sfc-gh-yzou added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 11, 2024
@sfc-gh-yzou sfc-gh-yzou force-pushed the yzou-SNOW-1632895-derive-dependency branch from 4ce7b9d to 61ef3b7 Compare September 11, 2024 23:45
@sfc-gh-yzou sfc-gh-yzou marked this pull request as ready for review September 12, 2024 16:23
@sfc-gh-yzou sfc-gh-yzou requested a review from a team as a code owner September 12, 2024 16:23
@sfc-gh-yzou sfc-gh-yzou force-pushed the yzou-SNOW-1632895-derive-dependency branch from 3ae6373 to a1bed4b Compare September 16, 2024 17:04
@sfc-gh-yzou sfc-gh-yzou merged commit 0ee3033 into main Sep 16, 2024
36 checks passed
@sfc-gh-yzou sfc-gh-yzou deleted the yzou-SNOW-1632895-derive-dependency branch September 16, 2024 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants