Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1527717: Add profiler snowpark API #2252

Merged
merged 76 commits into from
Oct 5, 2024
Merged

SNOW-1527717: Add profiler snowpark API #2252

merged 76 commits into from
Oct 5, 2024

Conversation

sfc-gh-yuwang
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-yuwang sfc-gh-yuwang marked this pull request as ready for review September 10, 2024 05:16
@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner September 10, 2024 05:16
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

sfc-gh-enie
sfc-gh-enie reviewed Sep 10, 2024
View reviewed changes
src/snowflake/snowpark/profiler.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/profiler.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/profiler.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/session.py Outdated Show resolved Hide resolved
sfc-gh-jrose
sfc-gh-jrose reviewed Sep 10, 2024
View reviewed changes
src/snowflake/snowpark/profiler.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/profiler.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

sfc-gh-aalam
sfc-gh-aalam approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 final changes requested but this looks good. Thanks for bearing with my Yuyang

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

sfc-gh-yixie
sfc-gh-yixie reviewed Oct 4, 2024
View reviewed changes
src/snowflake/snowpark/stored_procedure_profiler.py Outdated
f"stage name must be fully qualified name, got {stage} instead"
)
existing_stages = self._session.sql(
f"show stages like '{names[2]}' in schema {names[0]}.{names[1]}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If names[2] is doubled quoted, you may need to remove the double quote first.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-yuwang sfc-gh-yuwang merged commit 56a8ae2 into main Oct 5, 2024
34 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-1527717 branch October 5, 2024 00:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling left review comments

@sfc-gh-mabrennan sfc-gh-mabrennan sfc-gh-mabrennan left review comments

@sfc-gh-enie sfc-gh-enie sfc-gh-enie approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie approved these changes

@sfc-gh-jfreeberg sfc-gh-jfreeberg Awaiting requested review from sfc-gh-jfreeberg

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose

@sfc-gh-vbudati sfc-gh-vbudati Awaiting requested review from sfc-gh-vbudati sfc-gh-vbudati is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-nkrishna sfc-gh-nkrishna Awaiting requested review from sfc-gh-nkrishna sfc-gh-nkrishna is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sfc-gh-yuwang @sfc-gh-aalam @sfc-gh-mabrennan @sfc-gh-yixie @sfc-gh-aling @sfc-gh-enie @sfc-gh-jrose