-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1653121: Support some Timedelta aggregations on axis=0. #2248
Merged
sfc-gh-mvashishtha
merged 10 commits into
main
from
mvashishtha/SNOW-1653121/timedelta-axis-0-aggregations
Sep 13, 2024
Merged
SNOW-1653121: Support some Timedelta aggregations on axis=0. #2248
sfc-gh-mvashishtha
merged 10 commits into
main
from
mvashishtha/SNOW-1653121/timedelta-axis-0-aggregations
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
added
the
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
label
Sep 6, 2024
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
requested review from
sfc-gh-nkumar,
sfc-gh-yzou,
sfc-gh-azhan and
sfc-gh-nkrishna
and removed request for
sfc-gh-nkumar and
sfc-gh-yzou
September 6, 2024 21:44
marking as draft till I fix SNOW-1654730 |
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-nkrishna
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM!
sfc-gh-nkumar
approved these changes
Sep 13, 2024
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
deleted the
mvashishtha/SNOW-1653121/timedelta-axis-0-aggregations
branch
September 13, 2024 20:55
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SNOW-1653121
Test and support aggregation on axis=0. We still raise
NotImplementedError
if:To facilitate this change, introduce the class
SnowparkPandasAggFunc
, which represents a Snowpark pandas aggregation, together with the boolpreserves_snowpark_pandas_type
. We can useSnowparkPandasAggFunc
instead of the separate mappingsGROUPBY_AGG_PRESERVES_SNOWPARK_PANDAS_TYPE
andGROUPBY_AGG_WITH_NONE_SNOWPARK_PANDAS_TYPES
.This change also fixes the bug that timedelta aggregations like mean would produce the wrong type (and the wrong result) by truncating the float result if
preserves_snowpark_pandas_type
.