Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1649753 Fix a bug while setting None to timedelta column #2218

Merged
merged 1 commit into from
Sep 4, 2024
Merged

SNOW-1649753 Fix a bug while setting None to timedelta column #2218

merged 1 commit into from
Sep 4, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Sep 3, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1649753

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-azhan sfc-gh-azhan added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 3, 2024
@sfc-gh-azhan sfc-gh-azhan force-pushed the azhan-fix-1649753 branch 2 times, most recently from b46be2b to 20dd0e0 Compare September 4, 2024 16:55
@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review September 4, 2024 16:56
@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner September 4, 2024 16:56
sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sfc-gh-azhan sfc-gh-azhan merged commit e481c5c into main Sep 4, 2024
36 of 37 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-fix-1649753 branch September 4, 2024 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mvashishtha sfc-gh-mvashishtha sfc-gh-mvashishtha approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-azhan @sfc-gh-nkrishna @sfc-gh-mvashishtha