-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1649528 Fix monotonic bug #2217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-azhan
added
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
labels
Sep 3, 2024
sfc-gh-joshi
requested changes
Sep 3, 2024
sfc-gh-mvashishtha
approved these changes
Sep 3, 2024
sfc-gh-helmeleegy
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Thanks! But can you add a changelog entry under Bug Fixes
?
I didn't do because this feature has not been released yet. |
sfc-gh-azhan
force-pushed
the
azhan-fix-mono-1649528
branch
from
September 4, 2024 00:34
eaf6c52
to
6ad66c4
Compare
sfc-gh-joshi
approved these changes
Sep 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
snowpark-pandas
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1649528 Fix monotonic bug
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
This pull request includes several changes to improve the handling of monotonicity checks in the Snowflake Snowpark Modin integration and its corresponding tests. The most important changes include adding type checks for monotonicity, refining the logic for monotonicity checks in the query compiler, and expanding test cases to cover more scenarios.
Improvements to Monotonicity Checks:
src/snowflake/snowpark/modin/pandas/series.py
: Addedis_bool
checks to ensure the return values foris_monotonic_increasing
andis_monotonic_decreasing
are boolean. [1] [2]Refinements in Query Compiler:
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
: Improved the logic for adding columns used in monotonicity checks by incorporating conditional checks and ensuring proper handling of edge cases. [1] [2]Expanded Test Cases:
tests/integ/modin/index/test_monotonic.py
: Enhanced test cases for monotonic increasing and decreasing numbers to include empty lists and single-element lists. [1] [2]tests/integ/modin/series/test_monotonic.py
: Added new test cases to cover more scenarios, including empty lists and single-element lists, and introduced a test for type mismatches in monotonicity checks. [1] [2] [3]