-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-1649172]: Fix loc
set when setting DataFrame row with Series value
#2213
Conversation
# Conflicts: # CHANGELOG.md # src/snowflake/snowpark/modin/pandas/series.py # tests/integ/modin/frame/test_loc.py
src/snowflake/snowpark/modin/plugin/_internal/indexing_utils.py
Outdated
Show resolved
Hide resolved
Please describe what is the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe what was the issue?
src/snowflake/snowpark/modin/plugin/_internal/indexing_utils.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/indexing_utils.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/indexing_utils.py
Outdated
Show resolved
Hide resolved
Will add additional tests once the match by position or labels issue is resolved: https://snowflake.slack.com/archives/C04HF38JFAQ/p1727828020400139?thread_ts=1727824503.275869&cid=C04HF38JFAQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing the comments.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1649172
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
When doing
df.loc[x] = series
, an error occurs because series does not have the same number of columns as the dataframe being set. Instead, the Series should be transposed and set, regardless of whether it has an equal number of rows as the dataframe has columns.