Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1649210: Fix a bug where using to_pandas_batches with async jobs caused an error due to improper handling of waiting for asynchronous query completion. #2211

Merged
merged 1 commit into from
Sep 4, 2024
Merged

SNOW-1649210: Fix a bug where using to_pandas_batches with async jobs caused an error due to improper handling of waiting for asynchronous query completion. #2211

merged 1 commit into from
Sep 4, 2024

Conversation

sfc-gh-jdu
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1649210

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    We should rely on connector's get_results_from_sfqid to wait for results instead of executing result scan directly in Snowpark.

@sfc-gh-jdu sfc-gh-jdu requested a review from a team as a code owner September 3, 2024 18:50
@sfc-gh-jdu sfc-gh-jdu merged commit 75c615d into main Sep 4, 2024
34 of 35 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-SNOW-1649210-notebook branch September 4, 2024 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-jdu @sfc-gh-yixie @sfc-gh-aalam @sfc-gh-jrose