[SNOW-1649147]: Fix inplace argument for Series objects derived from DataFrames columns
#2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-rdurrani
commented
Sep 3, 2024
| @@ -2752,8 +2752,6 @@ def _update_inplace(self, new_query_compiler): | |||
| # Propagate changes back to parent so that column in dataframe had the same contents | |||
| if self._parent is not None: | |||
| if self._parent_axis == 0: | |||
There was a problem hiding this comment.
I removed the else, because it doesn't seem like self._parent_axis can be anything other than 1?
In [2]: df = pd.DataFrame([[1, 2, 3], [4, None, 6]], columns=list("ABC"))
In [3]: df['B']._parent_axis
Out[3]: 0
In [4]: df.loc[1]._parent_axis
Out[4]: 0
There was a problem hiding this comment.
@sfc-gh-joshi should we override this code? BTW, in indexing, we never use _parent_axis before.
There was a problem hiding this comment.
In our code base, we never set _parent_axis = 1.
There was a problem hiding this comment.
I think we should leave it as-is. We don't use it, but upstream modin uses it in DataFrame._getitem_column (which we don't use since we use a different code path for indexing).
There was a problem hiding this comment.
we now set _parent_axis=1 correctly: #2210
sfc-gh-rdurrani
added
the
NO-PANDAS-CHANGEDOC-UPDATES
sfc-gh-azhan
reviewed
Sep 3, 2024
sfc-gh-rdurrani
changed the title
inplace argument for Series objects derived from DataFramesinplace argument for Series objects derived from DataFrames columns
|
Fixed by #2210 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1649147
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.