-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1637102: Support binary operations between timedelta and number. #2200
Merged
sfc-gh-mvashishtha
merged 6 commits into
main
from
mvashishtha/SNOW-1637102/support-binary-operations-between-timedelta-and-number
Sep 4, 2024
Merged
SNOW-1637102: Support binary operations between timedelta and number. #2200
sfc-gh-mvashishtha
merged 6 commits into
main
from
mvashishtha/SNOW-1637102/support-binary-operations-between-timedelta-and-number
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-mvashishtha
added
the
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
label
Aug 30, 2024
sfc-gh-mvashishtha
requested review from
sfc-gh-dpetersohn,
sfc-gh-jkew,
sfc-gh-azhan and
sfc-gh-nkrishna
and removed request for
sfc-gh-dpetersohn and
sfc-gh-jkew
August 30, 2024 21:15
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-azhan
reviewed
Sep 3, 2024
src/snowflake/snowpark/modin/plugin/_internal/binary_op_utils.py
Outdated
Show resolved
Hide resolved
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Co-authored-by: Andong Zhan <[email protected]>
…ations-between-timedelta-and-number
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
sfc-gh-nkrishna
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM!
sfc-gh-azhan
approved these changes
Sep 4, 2024
sfc-gh-mvashishtha
deleted the
mvashishtha/SNOW-1637102/support-binary-operations-between-timedelta-and-number
branch
September 4, 2024 21:26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SNOW-1637102