Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1637102: Support binary operations between timedelta and number. #2200

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

Fixes SNOW-1637102

@sfc-gh-mvashishtha sfc-gh-mvashishtha added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Aug 30, 2024
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review August 30, 2024 21:15
@sfc-gh-mvashishtha sfc-gh-mvashishtha requested a review from a team as a code owner August 30, 2024 21:15
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM!

tests/integ/modin/binary/test_timedelta.py Show resolved Hide resolved
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 3240e5e into main Sep 4, 2024
34 of 35 checks passed
@sfc-gh-mvashishtha sfc-gh-mvashishtha deleted the mvashishtha/SNOW-1637102/support-binary-operations-between-timedelta-and-number branch September 4, 2024 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants