[SNOW-1514712] Support UDFs for Snowpark IR #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lspiegelberg
requested review from
sfc-gh-oplaton and
sfc-gh-azwiegincew
sfc-gh-lspiegelberg
requested review from
sfc-gh-jdu,
sfc-gh-aling,
sfc-gh-aalam and
sfc-gh-vbudati
and removed request for
a team,
sfc-gh-jdu,
sfc-gh-aling and
sfc-gh-aalam
sfc-gh-azwiegincew
approved these changes
Sep 3, 2024
sfc-gh-lspiegelberg
merged commit c7271ab
into
ls-SNOW-1491199-merge-phase0-server-side
6 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part I of supporting UDFs. This supports
udfdecorator.Other:
udf_utils.pythe case when inget_opt_arg_defaultsthe returned pythonarg_spec = inspect.getfullargspec(target_func)isNone. (Yes, this actually happens).conftest.pyfor the AST tests the initialization of the session. Previous init using constructors is incorrect, need to use builder pattern as session is not properly registered for_get_active_sessionelse.call_udfto more correctly become calling a builtin function.