SNOW-989398: Refactor resample.fillna to use ASOF Join
#2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-nkrishna
added
the
NO-PANDAS-CHANGEDOC-UPDATES
sfc-gh-nkrishna
changed the title
resample.fillna to use OrderedDataFrame join
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-vbudati
approved these changes
Aug 30, 2024
sfc-gh-evandenberg
approved these changes
Aug 30, 2024
src/snowflake/snowpark/modin/plugin/_internal/ordered_dataframe.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-yzou
reviewed
Aug 30, 2024
src/snowflake/snowpark/modin/plugin/_internal/ordered_dataframe.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/ordered_dataframe.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-nkrishna
changed the title
resample.fillna to use OrderedDataFrame joinresample.fillna to use OrderedDataFrame join
sfc-gh-nkrishna
changed the title
resample.fillna to use OrderedDataFrame joinresample.fillna to use ASOF Join
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-nkrishna
changed the title
resample.fillna to use ASOF Joinresample.fillna to use ASOF Join
sfc-gh-yzou
approved these changes
Sep 3, 2024
src/snowflake/snowpark/modin/plugin/_internal/resample_utils.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-yzou
reviewed
Sep 4, 2024
src/snowflake/snowpark/modin/plugin/_internal/resample_utils.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-nkrishna
added
the
NO-CHANGELOG-UPDATES
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-989398
This PR refactors
resample.fillna()to use theASOFJoin.