Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1644950: make use_logical_type option more explicit #2190

Merged
merged 5 commits into from
Sep 3, 2024
Merged

SNOW-1644950: make use_logical_type option more explicit #2190

merged 5 commits into from
Sep 3, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Aug 29, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1644950

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Move use_logical_type option outside of kwargs and make it more explicit. All existing tests should pass.

sfc-gh-aalam
sfc-gh-aalam commented Aug 29, 2024
View reviewed changes
CHANGELOG.md
- Added support for `ln` in `snowflake.snowpark.functions`
- Improved documentation for `Session.write_pandas` by making `use_logical_type` option more explicit.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed ln function since it is already added above.

@sfc-gh-aalam
Copy link
Contributor Author

sfc-gh-aalam commented Aug 29, 2024 •
edited
Loading

https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/1290/

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review August 30, 2024 22:12
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner August 30, 2024 22:12
sfc-gh-jrose
sfc-gh-jrose approved these changes Aug 30, 2024
View reviewed changes
src/snowflake/snowpark/session.py Outdated Show resolved Hide resolved
@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) August 30, 2024 22:21
@sfc-gh-aalam sfc-gh-aalam merged commit e9ea11a into main Sep 3, 2024
34 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1644950-add-explicit-option-for-use-logical-type branch September 3, 2024 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aalam @sfc-gh-aling @sfc-gh-jrose