Fix error message in python 3.8 to_snowpark_pandas daily test #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-joshi
requested review from
sfc-gh-yixie,
sfc-gh-aling and
sfc-gh-jrose
sfc-gh-jrose
approved these changes
Aug 27, 2024
sfc-gh-joshi
added
NO-CHANGELOG-UPDATES
sfc-gh-evandenberg
approved these changes
Aug 28, 2024
| @@ -47,9 +49,14 @@ def test_to_snowpark_pandas_no_modin(session, tmp_table_basic): | |||
| # TODO: SNOW-1552497: after upgrading to modin 0.30.1, Snowpark pandas will support | |||
| # all pandas 2.2.x, and this function call will raise a ModuleNotFoundError since | |||
| # modin is not installed. | |||
| match = ( | |||
| "Snowpark pandas does not support Python 3.8. Please update to Python 3.9 or later" | |||
| if sys.version_info.major == 3 and sys.version_info.minor == 8 | |||
There was a problem hiding this comment.
Do we care about message for earlier versions of python, ie. < 3.8 ?
There was a problem hiding this comment.
Within Snowpark pandas, we currently check if the version ==3.8. Older Python versions have been EOL'd anyway, and even if a user somehow manages to set up a Snowpark (pandas or non-pandas) environment, they would encounter an error when trying to import pandas anyway since pandas 2.1+ only works with Python 3.9 and later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Updates the error message to check if we're on python 3.8 before checking the pandas version.