-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1625379 Test coverage for timedelta under modin/integ/frame part 1 #2171
Conversation
7e7372d
to
6fe524b
Compare
@@ -111,7 +118,7 @@ class SnowparkPandasColumn(NamedTuple): | |||
snowpark_pandas_type: Optional[SnowparkPandasType] | |||
|
|||
|
|||
class TimedeltaType(SnowparkPandasType, LongType): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SnowparkPandasType
already extends DataType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits, but approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits on the tests
d8eb981
to
992bee9
Compare
ac9af50
to
2901895
Compare
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
2901895
to
40994a3
Compare
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1625379 Test coverage for timedelta under modin/integ/frame part 1
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
This pull request includes several changes to enhance support for the
Timedelta
type, improve type handling, and add new test cases. The most important changes include adding support for variousTimedelta
operations, enhancing type checking and handling, and introducing new test cases to ensure the robustness of these features.Enhancements to
Timedelta
Support:Timedelta
type in various operations likefillna
,diff
,duplicated
,empty
,insert
,isin
,isna
,items
,iterrows
,join
,len
,melt
,nlargest
, andnsmallest
in theCHANGELOG.md
file.NotImplementedError
forTimedelta
in methods such asinsert
,melt
, andmerge
insnowflake_query_compiler.py
. [1] [2] [3]Improvements in Type Handling:
type_match
method inSnowparkPandasType
class to check type compatibility._simple_unpivot
function to handleSnowparkPandasType
correctly and added type information for unpivoted columns. [1] [2] [3] [4] [5]fillna
anddiff
methods to maintainSnowparkPandasType
consistency after operations. [1] [2]New Test Cases:
Timedelta
type inassign
,ffill
,bfill
, anddiff
methods to ensure proper functionality. [1] [2] [3] [4]Timedelta
type intest_compare.py
to validate comparison operations. [1] [2]These changes collectively improve the handling and support of the
Timedelta
type, ensuring more robust and comprehensive functionality across various operations.