Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1549041: Add doc and fix description of function ln #2170

Merged
merged 4 commits into from
Aug 28, 2024
Merged

SNOW-1549041: Add doc and fix description of function ln #2170

merged 4 commits into from
Aug 28, 2024

Conversation

sfc-gh-yuwang
Copy link
Collaborator

@sfc-gh-yuwang sfc-gh-yuwang commented Aug 27, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1549041

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yuwang sfc-gh-yuwang requested a review from a team as a code owner August 27, 2024 00:01
sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, can you update the description to include the Jira info?

src/snowflake/snowpark/functions.py Outdated
@@ -5932,7 +5932,8 @@ def vector_inner_product(v1: ColumnOrName, v2: ColumnOrName) -> Column:


def ln(c: ColumnOrLiteral) -> Column:
"""Returns the natrual log product of given column expression
"""Returns the natrual log of given column expression.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Returns the natrual log of given column expression.
"""Returns the natural logarithm of given column expression.

@sfc-gh-yuwang sfc-gh-yuwang changed the title Add doc and fix description of function ln SNOW-1549041: Add doc and fix description of function ln Aug 28, 2024
@sfc-gh-yuwang sfc-gh-yuwang merged commit 572d01d into main Aug 28, 2024
32 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the yuwang-add-ln-to-rst branch August 28, 2024 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-yuwang @sfc-gh-aalam @sfc-gh-evandenberg @sfc-gh-jrose