Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1619272: fix explode outer parameter type casting causing dynamic table creation failure #2154

Merged
merged 5 commits into from
Aug 29, 2024
Merged

SNOW-1619272: fix explode outer parameter type casting causing dynamic table creation failure #2154

merged 5 commits into from
Aug 29, 2024

Conversation

sfc-gh-aling
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1619272

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

backend function FLATTEN_CONSTRUCT doesn't accept False::BOOLEAN but accept False.
to bypass the issue, we don't cast type if the input value is of boolean type on the client side

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

1 similar comment
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review August 23, 2024 16:49
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner August 23, 2024 16:49
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

sfc-gh-aalam
sfc-gh-aalam approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since we also use the same cast when analyzing FunctionExpression

@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-1619272-create-or-dynamic-table-fails-when-used-with-explode branch from ccb02af to 63acb6b Compare August 26, 2024 17:49
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment otherwise LGTM

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-aling
Copy link
Contributor Author

daily precommit running: https://github.com/snowflakedb/snowpark-python/actions/runs/10620281367

@sfc-gh-aling sfc-gh-aling merged commit 07754ec into main Aug 29, 2024
89 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1619272-create-or-dynamic-table-fails-when-used-with-explode branch August 29, 2024 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie left review comments

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-aling @sfc-gh-jdu @sfc-gh-yixie @sfc-gh-aalam @sfc-gh-evandenberg