-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1458135 Implement DataFrame and Series initialization with lazy Index objects #2137
Merged
sfc-gh-vbudati
merged 68 commits into
main
from
vbudati/SNOW-1458135-df-series-init-with-lazy-index
Sep 25, 2024
Merged
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
2094c3f
Update Series and DataFrame constructors to handle lazy Index objects…
sfc-gh-vbudati 97a7229
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 1979257
update changelog
sfc-gh-vbudati 5dbb76d
add more tests
sfc-gh-vbudati 7de467f
fix minor bug
sfc-gh-vbudati 5dd06fd
fix isocalendar docstring error
sfc-gh-vbudati 8b94462
truncate tests, update changelog wording, reduce 2 queries to one que…
sfc-gh-vbudati c89dc5d
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati a2089b8
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati a9376c1
Get rid of the join performed when only index is an Index object and …
sfc-gh-vbudati 420a5ac
Add back the index join query to DataFrame/Series constructor, update…
sfc-gh-vbudati 66d634c
Update tests
sfc-gh-vbudati f277041
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 6a2cb79
added edge case logic, fix test query count
sfc-gh-vbudati df96f4a
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati f971b0d
more test fixes
sfc-gh-vbudati 13db956
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 8c78f8d
fix dict case
sfc-gh-vbudati 7970101
more test case fixes
sfc-gh-vbudati f3de1c3
correct the logic for series created with dict and index
sfc-gh-vbudati 2447022
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 82728bf
fix query counts
sfc-gh-vbudati 23587a4
Merge branch 'vbudati/SNOW-1458135-df-series-init-with-lazy-index' of…
sfc-gh-vbudati 1577ddc
fix join count
sfc-gh-vbudati 8903f60
refactor series and df
sfc-gh-vbudati 668c889
merge main into current branch
sfc-gh-vbudati 67a07c1
refactor dataframe and series constructors
sfc-gh-vbudati a4351ba
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 1453680
fix docstring tests
sfc-gh-vbudati f39e751
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati b73f027
fix some tests
sfc-gh-vbudati c6fc05d
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati d422f86
replace series constructor
sfc-gh-vbudati 1ea5d00
fix tests
sfc-gh-vbudati 024acd8
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati f4a80f3
fix loc and iloc tests
sfc-gh-vbudati ce1ffa6
fix test
sfc-gh-vbudati 00d2a8b
fix test
sfc-gh-vbudati cb91849
fix last valid index error
sfc-gh-vbudati d9fdbb0
remove stuff unnecessarily commented out
sfc-gh-vbudati 3d5b785
explain high query count
sfc-gh-vbudati 7f9dbaa
rewrite binary op test, fix coverage
sfc-gh-vbudati 6de9f49
fix tests
sfc-gh-vbudati c2fb474
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 2274d1e
remove print statements and unnecessary comments
sfc-gh-vbudati 9eef8d7
fix tests
sfc-gh-vbudati cc09403
increase coverage
sfc-gh-vbudati 10c3954
try to move out common logic, add more tests
sfc-gh-vbudati 64dda24
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati da56734
update df init
sfc-gh-vbudati 8b47e17
moved common logic out, fixed some tests
sfc-gh-vbudati fa4eb09
remove unnecessary diffs
sfc-gh-vbudati db28630
fix doctest and couple of tests
sfc-gh-vbudati 17be4c3
apply feedback to simplify logic
sfc-gh-vbudati 301f47f
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 2eb14a7
update query counts to use constants
sfc-gh-vbudati 95065f7
Merge branch 'vbudati/SNOW-1458135-df-series-init-with-lazy-index' of…
sfc-gh-vbudati d9bbd9b
remove docstring update, add docstrings for helper functions
sfc-gh-vbudati f40c5b4
try to break down df init into three steps: data, columns, and index
sfc-gh-vbudati 8cce409
merge main into current branch
sfc-gh-vbudati f37b80a
add dtype logic
sfc-gh-vbudati 83de657
merge main into current branch
sfc-gh-vbudati 57bf89c
fix tests
sfc-gh-vbudati 8ed8e5b
reduce git diff, add xfails instead of modifying tests
sfc-gh-vbudati cea97e0
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 03a68dc
Address feedback
sfc-gh-vbudati 19af4bb
Merge branch 'main' into vbudati/SNOW-1458135-df-series-init-with-laz…
sfc-gh-vbudati 1eb17dd
add changelog entry about non-existent columns/index values being sup…
sfc-gh-vbudati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this new line as well