Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1618623 lazy index: refactor qc as input for index constructor #2045

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Aug 7, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1618623

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

lazy index:

  • refactor qc as input for index constructor and make it consistent with other init methos like dataframe and series.
  • raise ValueError for pd.Index(df)

@sfc-gh-azhan sfc-gh-azhan added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Aug 7, 2024
@sfc-gh-azhan sfc-gh-azhan force-pushed the azhan-test-index branch 2 times, most recently from eea812e to 3f58c27 Compare August 8, 2024 18:10
@sfc-gh-azhan sfc-gh-azhan changed the title remove qc SNOW-1618623 lazy index: refactor qc as input for index constructor Aug 8, 2024
@sfc-gh-azhan sfc-gh-azhan removed the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 8, 2024
@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review August 8, 2024 18:15
@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner August 8, 2024 18:15
@sfc-gh-azhan sfc-gh-azhan marked this pull request as draft August 8, 2024 18:51
@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review August 8, 2024 19:32
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfc-gh-azhan sfc-gh-azhan force-pushed the azhan-test-index branch 4 times, most recently from 20db574 to 107b965 Compare August 9, 2024 17:09
@sfc-gh-azhan sfc-gh-azhan merged commit 3459a4f into main Aug 9, 2024
35 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-test-index branch August 9, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants