-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1618623 lazy index: refactor qc as input for index constructor #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-azhan
added
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
labels
Aug 7, 2024
sfc-gh-azhan
force-pushed
the
azhan-test-index
branch
2 times, most recently
from
August 8, 2024 18:10
eea812e
to
3f58c27
Compare
sfc-gh-azhan
changed the title
remove qc
SNOW-1618623 lazy index: refactor qc as input for index constructor
Aug 8, 2024
sfc-gh-azhan
force-pushed
the
azhan-test-index
branch
from
August 8, 2024 18:14
3f58c27
to
1983e2a
Compare
sfc-gh-azhan
removed
the
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
label
Aug 8, 2024
sfc-gh-azhan
requested review from
sfc-gh-nkrishna,
sfc-gh-mvashishtha,
sfc-gh-nkumar and
sfc-gh-yzou
August 8, 2024 18:15
sfc-gh-mvashishtha
approved these changes
Aug 8, 2024
sfc-gh-nkrishna
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sfc-gh-azhan
force-pushed
the
azhan-test-index
branch
4 times, most recently
from
August 9, 2024 17:09
20db574
to
107b965
Compare
sfc-gh-azhan
force-pushed
the
azhan-test-index
branch
from
August 9, 2024 17:44
107b965
to
3c915f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1618623
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
lazy index:
pd.Index(df)