Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1529332: Remove private_preview decorator for create_or_replace_dynamic_table #1905

Merged
merged 1 commit into from
Jul 12, 2024
Merged

SNOW-1529332: Remove private_preview decorator for create_or_replace_dynamic_table #1905

merged 1 commit into from
Jul 12, 2024

Conversation

sfc-gh-jdu
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1529332: Expose DataFrame.create_or_replace_dynamic_table since dynamic table is no longer in preview #1897

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    It's already out of preview.

@sfc-gh-jdu sfc-gh-jdu requested a review from a team as a code owner July 11, 2024 18:36
@sfc-gh-jdu sfc-gh-jdu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 11, 2024
sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-jdu sfc-gh-jdu merged commit c0c8e90 into main Jul 12, 2024
32 of 35 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-SNOW-1529332-rm-pr branch July 12, 2024 21:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

@sfc-gh-smirzaei sfc-gh-smirzaei Awaiting requested review from sfc-gh-smirzaei sfc-gh-smirzaei is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-1529332: Expose DataFrame.create_or_replace_dynamic_table since dynamic table is no longer in preview
3 participants
@sfc-gh-jdu @sfc-gh-evandenberg @sfc-gh-jrose