Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to expression when there is ignore nulls and offset != 0 #1888

Closed

Conversation

frederiksteiner
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1526571

#1887

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  2. Please describe how your code solves the related issue.

    Previously, when using lead and lag on the specified table, they returned a NullType column in local testing. Now it should return the proper type.

@sfc-gh-jrose
Copy link
Contributor

Thanks for the PR. Do you have an example for when you observed the errant behavior that this PR fixes?

@frederiksteiner
Copy link
Contributor Author

There should be an example in the issue that I linked: https://snowflakecomputing.atlassian.net/browse/SNOW-1526571

@sfc-gh-jrose sfc-gh-jrose requested a review from a team July 10, 2024 00:36
@sfc-gh-jrose sfc-gh-jrose added the local testing Local Testing issues/PRs label Jul 11, 2024
@frederiksteiner
Copy link
Contributor Author

Commits added to this PR #1959 and merged

@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
local testing Local Testing issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants