Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pytest markers #1768

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

sfc-gh-stan
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    This is a test config only changes. I'm removing all pytest.mark.localtest because we run Local Testing against all tests now. In addition, I removed a few typos like pytest.mark.local and pytest.mark.locatest. I also removed scala from tox.ini because there are no tests marked with pytest.mark.scala, this dangling marker generates a pytest warning.

@sfc-gh-stan sfc-gh-stan requested review from a team as code owners June 12, 2024 22:20
@sfc-gh-stan sfc-gh-stan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jun 12, 2024
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jun 12, 2024
@sfc-gh-stan sfc-gh-stan requested review from sfc-gh-jrose and sfc-gh-aalam and removed request for sfc-gh-yuwang June 12, 2024 22:20
@sfc-gh-stan sfc-gh-stan force-pushed the stan-remove-unused-test-markers branch from d1ef65d to 3f44d0c Compare June 13, 2024 23:09
@sfc-gh-stan sfc-gh-stan enabled auto-merge (squash) June 13, 2024 23:09
@sfc-gh-stan sfc-gh-stan merged commit 721f942 into main Jun 13, 2024
34 checks passed
@sfc-gh-stan sfc-gh-stan deleted the stan-remove-unused-test-markers branch June 13, 2024 23:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
local testing Local Testing issues/PRs NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants