-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1433003 raise NotImplementedError for Index APIs #1750
SNOW-1433003 raise NotImplementedError for Index APIs #1750
Conversation
… remove Series comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating all these docstrings -- left a few comments. Can we also add an index.rst (okay if we do in a follow-up PR)?
@sfc-gh-nkrishna there is a separate PR for documentation here: #1751 |
except AttributeError as err: | ||
if not key.startswith("_"): | ||
native_index = native_pd.Index([]) | ||
if hasattr(native_index, key): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-vbudati can you add a quick comment here that "any methods that not supported by the current Index.py but exists in native pandas index object should raise a not implemented error for now"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I missed this - I'll add it in the documentation PR here: #1751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1433003
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Raising NotImplementedError for Index APIs that have not been implemented. I also added documentation for them, and it should be tested.