SNOW-1284606 Move running_on_* to tests/utils.py #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-azhan
requested review from
sfc-gh-rdurrani,
sfc-gh-nkrishna,
sfc-gh-yixie,
sfc-gh-yuwang and
sfc-gh-jrose
sfc-gh-azhan
added
NO-CHANGELOG-UPDATES
sfc-gh-azhan
force-pushed
the
azhan-move-1284606
branch
from
ef4d1c7 to
7678d47
Compare
sfc-gh-azhan
force-pushed
the
azhan-move-1284606
branch
from
7678d47 to
feda0bb
Compare
sfc-gh-lmukhopadhyay
approved these changes
Jun 5, 2024
sfc-gh-jdu
approved these changes
Jun 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those running_on_* methods was in
tests/integ/conftest.pywhich requirestests.parametersavailable. It blocks us to use them in sproc tests since there is notests.parametersthere.