Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: ignore some not implemented methods code coverage #1736

Merged
merged 2 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/snowflake/snowpark/modin/plugin/docstrings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@
"""


class BasePandasDataset: # pragma: no cover: we use this class's docstrings, but we never execute its methods.
class BasePandasDataset:
"""
Implement most of the common code that exists in DataFrame/Series.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
}


class DataFrame: # pragma: no cover: we use this class's docstrings, but we never execute its methods.
class DataFrame:
"""
Snowpark pandas representation of ``pandas.DataFrame`` with a lazily-evaluated relational dataset.

Expand Down
4 changes: 2 additions & 2 deletions src/snowflake/snowpark/modin/plugin/docstrings/groupby.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
)


class DataFrameGroupBy: # pragma: no cover: we use this class's docstrings, but we never execute its methods.
class DataFrameGroupBy:
def __getattr__():
"""
Alter regular attribute access, looks up the name in the columns.
Expand Down Expand Up @@ -1872,7 +1872,7 @@ def pipe():
pass


class SeriesGroupBy: # pragma: no cover: we use this class's docstrings, but we never execute its methods.
class SeriesGroupBy:
@property
def ndim(self):
"""
Expand Down
4 changes: 2 additions & 2 deletions src/snowflake/snowpark/modin/plugin/docstrings/resample.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
from textwrap import dedent


class Resampler: # pragma: no cover: we use this class's docstrings, but we never execute its methods.
def __getitem__(self, key): # pragma: no cover
class Resampler:
def __getitem__(self, key):
"""
Get ``Resampler`` based on `key` columns of original dataframe.

Expand Down
2 changes: 1 addition & 1 deletion src/snowflake/snowpark/modin/plugin/docstrings/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}


class Series: # pragma: no cover: we use this class's docstrings, but we never execute its methods.
class Series:
"""
Snowpark pandas representation of `pandas.Series` with a lazily-evaluated relational dataset.

Expand Down
30 changes: 15 additions & 15 deletions src/snowflake/snowpark/modin/plugin/io/snow_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def read_gbq(
progress_bar_type=None,
max_results=None,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -588,17 +588,17 @@ def read_html(
displayed_only=True,
**kwargs,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
def read_clipboard(cls, sep=r"\s+", **kwargs):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
def read_excel(cls, **kwargs):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -616,7 +616,7 @@ def read_hdf(
chunksize=None,
**kwargs,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -625,7 +625,7 @@ def read_feather(
path,
**kwargs,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -634,7 +634,7 @@ def read_stata(
filepath_or_buffer,
**kwargs,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -649,7 +649,7 @@ def read_sas(
iterator=False,
**kwargs,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -658,7 +658,7 @@ def read_pickle(
filepath_or_buffer,
**kwargs,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -675,7 +675,7 @@ def read_sql(
dtype_backend=no_default,
dtype=None,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -691,7 +691,7 @@ def read_fwf(
chunksize=None,
**kwds,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -707,7 +707,7 @@ def read_sql_table(
chunksize=None,
dtype_backend=no_default,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -717,12 +717,12 @@ def read_sql_query(
con,
**kwargs,
):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
def read_spss(cls, path, usecols, convert_categoricals, dtype_backend):
pass
pass # pragma: no cover

@classmethod
@pandas_module_level_function_not_implemented()
Expand All @@ -732,4 +732,4 @@ def to_pickle(
filepath_or_buffer,
**kwargs,
):
pass
pass # pragma: no cover
6 changes: 4 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
[coverage:report]
skip_covered = False
show_missing = True
# TODO: SNOW-1453027 remove omit
# TODO: SNOW-1453027 remove omit for config and core
omit = */src/snowflake/snowpark/modin/config/*
*/src/snowflake/snowpark/modin/core/*
*/src/snowflake/snowpark/modin/plugin/docstrings/*
sfc-gh-azhan marked this conversation as resolved.
Show resolved Hide resolved
[coverage:run]
branch = true
parallel = true
concurrency = multiprocessing
# TODO: SNOW-1453027 remove omit
# TODO: SNOW-1453027 remove omit for config and core
omit = */src/snowflake/snowpark/modin/config/*
*/src/snowflake/snowpark/modin/core/*
*/src/snowflake/snowpark/modin/plugin/docstrings/*
[coverage:paths]
source = src/snowflake/snowpark
*/.tox/*/lib/python*/site-packages/snowflake/snowpark
Expand Down
Loading