SNOW-1435354: Add CTE optimization tests to snowpark pandas daily precommit tests #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jdu
added
the
NO-CHANGELOG-UPDATES
sfc-gh-jdu
force-pushed
the
jdu-SNOW-1435354-cte-pandas-test
branch
3 times, most recently
from
2c9263a to
0c89e71
Compare
7 tasks
sfc-gh-jdu
force-pushed
the
jdu-SNOW-1435354-cte-pandas-test
branch
4 times, most recently
from
beed1b3 to
69207c3
Compare
sfc-gh-jdu
force-pushed
the
jdu-SNOW-1435354-cte-pandas-test
branch
from
69207c3 to
368fac1
Compare
sfc-gh-jdu
requested review from
sfc-gh-nkumar,
sfc-gh-joshi,
sfc-gh-stan,
sfc-gh-yuwang,
sfc-gh-jrose,
sfc-gh-yzou and
sfc-gh-aalam
sfc-gh-jdu
commented
Jun 6, 2024
sfc-gh-jrose
approved these changes
Jun 6, 2024
sfc-gh-azhan
reviewed
Jun 7, 2024
sfc-gh-yzou
reviewed
Jun 10, 2024
| PARAMETER_PASSWORD: ${{ secrets.PARAMETER_PASSWORD }} | ||
| CLOUD_PROVIDER: ${{ matrix.cloud-provider }} | ||
| - name: Download wheel(s) | ||
| uses: actions/download-artifact@v3 |
sfc-gh-yzou
reviewed
Jun 10, 2024
| matrix: | ||
| os: | ||
| - image_name: macos-latest | ||
| download_name: macos # it includes doctest |
There was a problem hiding this comment.
it seems we are using macos for most daily runs, but we have larger machines for linux and windows, shall we use a different one?
There was a problem hiding this comment.
Now you use ubuntu to run doctests which is new to us. So it may have different behavior than macos. Just a reminder
sfc-gh-yzou
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1435354
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add CTE optimization tests to snowpark pandas daily precommit tests. A successful run: https://github.com/snowflakedb/snowpark-python/actions/runs/9406047620