SNOW-1296603: Add daily precommit test #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jdu
added
the
NO-CHANGELOG-UPDATES
sfc-gh-jdu
force-pushed
the
jdu-SNOW-1296603-daily-jon
branch
from
d253f19 to
3746d7a
Compare
sfc-gh-yzou
reviewed
Apr 11, 2024
| fail-fast: false | ||
| matrix: | ||
| os: | ||
| - image_name: macos-latest |
There was a problem hiding this comment.
@sfc-gh-jdu for this test, do you need to run it all on macos? if not, maybe run it on the larger machien
There was a problem hiding this comment.
per our offline discussion, macos is required to run doctests, so let's keep it using mac for now
| fail-fast: false | ||
| matrix: | ||
| os: | ||
| - image_name: macos-latest |
There was a problem hiding this comment.
maybe use a the larger machine for this one also?
| matrix: | ||
| os: | ||
| - image_name: macos-latest | ||
| download_name: macos # it includes doctest |
There was a problem hiding this comment.
maybe use larger machine for this one also
sfc-gh-yuwang
approved these changes
Apr 11, 2024
sfc-gh-aling
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add daily precommit tests. An example here https://github.com/snowflakedb/snowpark-python/actions/runs/8637285804