Add support for snow:// stage paths
#1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
5 tasks
sfc-gh-dhung
force-pushed
the
dhung-snowurl-support
branch
from
fe34106 to
a6896c1
Compare
sfc-gh-dhung
force-pushed
the
dhung-snowurl-support
branch
from
ad1aaa4 to
1e4ec14
Compare
sfc-gh-aalam
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
LGTM. Running SP tests here: https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/1001/
Relevant tests related to this change passed. Only failures are also open issues right now
|
sfc-gh-stan
approved these changes
Apr 4, 2024
sfc-gh-stan
reviewed
Apr 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1282839: Add support for SnowURLs #1345
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Adds support for
snow://prefixed stage paths. Also fixes a bug where local file path is incorrectly extracted from single quoted paths:'@path/file'->file'(note trailing quote)