-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of to_pandas() when having integer column with null values #1232
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@frederiksteiner could you add a changelog about the fix you just added and comment "recheck" to rerun the CLA Assistant merge gate |
recheck |
I hope I did it properly. It says that I did not sign the CLA but I did that already |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes LGTM but I think we should include this in 1.13.0 minor release instead of doing a separate patch release. [Update]: Confirmed with Afroz we will release 1.12.1
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1026241
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
When there is a NaN value in the column, it does not try to cast it to integer but keeps it as float64