Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of to_pandas() when having integer column with null values #1232

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

frederiksteiner
Copy link
Contributor

@frederiksteiner frederiksteiner commented Feb 1, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1026241

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    When there is a NaN value in the column, it does not try to cast it to integer but keeps it as float64

Copy link

github-actions bot commented Feb 1, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@frederiksteiner
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-aalam
Copy link
Contributor

recheck

@sfc-gh-aalam
Copy link
Contributor

@frederiksteiner could you add a changelog about the fix you just added and comment "recheck" to rerun the CLA Assistant merge gate

@frederiksteiner
Copy link
Contributor Author

recheck

@frederiksteiner
Copy link
Contributor Author

frederiksteiner commented Feb 2, 2024

I hope I did it properly. It says that I did not sign the CLA but I did that already

@frederiksteinerSBB
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@frederiksteinerSBB
Copy link
Contributor

recheck

Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM but I think we should include this in 1.13.0 minor release instead of doing a separate patch release. [Update]: Confirmed with Afroz we will release 1.12.1

@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) February 6, 2024 21:27
@sfc-gh-aalam sfc-gh-aalam merged commit 39f83e8 into snowflakedb:main Feb 7, 2024
66 of 113 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1026241: Null value in integer column raises exception when executing .to_pandas() in version 1.12.0
4 participants