Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-786887: implement df.to_pandas #1117

Merged
merged 8 commits into from
Nov 17, 2023
Merged

SNOW-786887: implement df.to_pandas #1117

merged 8 commits into from
Nov 17, 2023

Conversation

sfc-gh-aling
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-786887-local-testing-dataframe-to-pandas-data-frame-to-pandas-batches branch from e1897bd to 8ed441c Compare November 6, 2023 19:10
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review November 6, 2023 19:11
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner November 6, 2023 19:11
@sfc-gh-aling sfc-gh-aling requested review from sfc-gh-stan and sfc-gh-achandrasekaran and removed request for a team November 6, 2023 19:11
sfc-gh-stan
sfc-gh-stan approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

@sfc-gh-aling sfc-gh-aling merged commit cb4d1e4 into dev/local-testing Nov 17, 2023
1 check passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-786887-local-testing-dataframe-to-pandas-data-frame-to-pandas-batches branch November 17, 2023 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-achandrasekaran sfc-gh-achandrasekaran Awaiting requested review from sfc-gh-achandrasekaran sfc-gh-achandrasekaran is a code owner automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aling @sfc-gh-stan