Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Local Testing] SNOW-929078 Support Table.update/delete/merge #1107

Merged
merged 5 commits into from
Nov 17, 2023
Merged

[Local Testing] SNOW-929078 Support Table.update/delete/merge #1107

merged 5 commits into from
Nov 17, 2023

Conversation

sfc-gh-stan
Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan commented Oct 25, 2023 •
edited
Loading

  • Refactor and clean up the code
  • Randomize name of added temporary columns "row_id" and 'source_row_id"
  • Create ticket for supporting behavior when ERROR_ON_NONDETERMINISTIC_MERGE or ERROR_ON_NONDETERMINISTIC_UPDATE is true

sfc-gh-yixie
sfc-gh-yixie reviewed Oct 26, 2023
View reviewed changes
tests/integ/scala/test_update_delete_merge_suite.py
)


@pytest.mark.localtest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't check the column names and types in these live tests so no assertions on column types to the local test. How about adding some assertions?

@sfc-gh-stan sfc-gh-stan force-pushed the local/support-table-update-delete-merge branch from 62a56f0 to 4cbd8d8 Compare November 3, 2023 16:06
@sfc-gh-stan sfc-gh-stan force-pushed the local/support-table-update-delete-merge branch from 4cbd8d8 to d356b5a Compare November 3, 2023 16:07
@sfc-gh-stan sfc-gh-stan marked this pull request as ready for review November 6, 2023 22:27
@sfc-gh-stan sfc-gh-stan requested a review from a team as a code owner November 6, 2023 22:27
@sfc-gh-stan sfc-gh-stan requested review from sfc-gh-mkeller and sfc-gh-bwarsaw and removed request for a team November 6, 2023 22:27
sfc-gh-aling
sfc-gh-aling approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-stan sfc-gh-stan merged commit bff4206 into dev/local-testing Nov 17, 2023
8 of 39 checks passed
@sfc-gh-stan sfc-gh-stan deleted the local/support-table-update-delete-merge branch November 17, 2023 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller sfc-gh-mkeller is a code owner automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-bwarsaw sfc-gh-bwarsaw Awaiting requested review from sfc-gh-bwarsaw sfc-gh-bwarsaw is a code owner automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-stan @sfc-gh-yixie @sfc-gh-aling