SNOW-911327: Use CTAS for save as table #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
commented
Oct 3, 2023
Comment on lines
-2309
to
-2313
| @pytest.mark.parametrize("table_type", ["", "temp", "temporary", "transient"]) | ||
| @pytest.mark.parametrize( | ||
| "save_mode", ["append", "overwrite", "ignore", "errorifexists"] | ||
| ) | ||
| def test_save_as_table_respects_schema(session, save_mode, table_type): |
There was a problem hiding this comment.
removing excessive table_type parametrization for tests which don't provide any additional value in the test. I do want to listen to team's opinion on this
sfc-gh-sfan
reviewed
Oct 3, 2023
We only revert CTAS -> create+insert statement but keeping the NULL changes. In the first PR, I didn't know it was possible to enforce schema nulls using CTAS until yijun showed it to me. Note we haven't removed any nullable schema tests that were added earlier. |
sfc-gh-sfan
approved these changes
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-912320: The behavior of
save_as_table(mode='overwrite')is inconsistent between v1.5.1 and v1.6.1 #1046, #SNOW-911327Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
In PR SNOW-817445: Fix dataframe writer save_as_table allow nulls #895 we started using create-table-insert-values pattern instead of using a CTAS pattern for saving dataframes. This is causing issues for multiple users so we are using CTAS while also respecting nullable columns. The tests added before also work for the correctness of this change.