Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Local Testing] SNOW-904260 support dataframe na functions #1069

Merged
merged 8 commits into from
Nov 6, 2023
Merged

[Local Testing] SNOW-904260 support dataframe na functions #1069

merged 8 commits into from
Nov 6, 2023

Conversation

sfc-gh-stan
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-stan sfc-gh-stan force-pushed the local/support-dataframe-na-functions branch from 7d86157 to 370bd57 Compare October 30, 2023 20:31
@sfc-gh-stan sfc-gh-stan marked this pull request as ready for review November 1, 2023 01:26
@sfc-gh-stan sfc-gh-stan requested a review from a team as a code owner November 1, 2023 01:26
@sfc-gh-stan sfc-gh-stan force-pushed the local/support-dataframe-na-functions branch from eb4605e to 7c1bd53 Compare November 6, 2023 16:46
@sfc-gh-stan sfc-gh-stan merged commit b24d529 into dev/local-testing Nov 6, 2023
7 of 39 checks passed
@sfc-gh-stan sfc-gh-stan deleted the local/support-dataframe-na-functions branch November 6, 2023 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-stan @sfc-gh-aling