SNOW-903907: Fix custom package uplaod bug #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
added
the
NO-CHANGELOG-UPDATES
5 tasks
sfc-gh-sfan
reviewed
Sep 21, 2023
src/snowflake/snowpark/session.py
Outdated
| f"Cannot add dependency package '{name}=={version}' " | ||
| f"because {result_dict[name]} is already added." | ||
| ) | ||
| else: |
There was a problem hiding this comment.
nit: this else can be removed
| ) | ||
| if version is not None: | ||
| added_package_has_version = "==" in result_dict[name] | ||
| if added_package_has_version and result_dict[name] != str(package): |
There was a problem hiding this comment.
Can we add a comment about what an entry of result_dict looks like and what package looks like? It's not obvious to me why result_dict[name] != str(package) is correct 🤔
There was a problem hiding this comment.
added a comment to explain how things look
sfc-gh-sfan
approved these changes
Sep 22, 2023
sfc-gh-aalam
deleted the
aalam-SNOW-903907-fix-custom-package-upload
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-903907
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The test is already present in
test_packaging::test_add_requirements_unsupported_with_cache_pathwhich is failing on merge gates on 3.9/3.10 runtimes. The fix is to get merge-gates back