SNOW-1320309: Remove unnecessary warning from sort_values #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-joshi
approved these changes
Sep 17, 2024
|
Do we have any tests for this warning behavior? |
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1320309-quicksort
branch
from
9204047 to
2f713e5
Compare
sfc-gh-nkumar
added
the
NO-PANDAS-CHANGEDOC-UPDATES
…ompiler.py Co-authored-by: Naren Krishna <[email protected]>
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1320309-quicksort
branch
from
2f713e5 to
f7c96ee
Compare
sfc-gh-evandenberg
approved these changes
Sep 19, 2024
| @@ -15,6 +15,7 @@ | |||
| - Improved `to_pandas` to persist the original timezone offset for TIMESTAMP_TZ type. | |||
| - Improved `dtype` results for TIMESTAMP_TZ type to show correct timezone offset. | |||
| - Improved error message when passing non-bool value to `numeric_only` for groupby aggregations. | |||
| - Removed unnecessary warning about sort algorithm in `sort_values`. | |||
There was a problem hiding this comment.
This seems so minor, is it even worth calling out as an improvement?
There was a problem hiding this comment.
yeah, it is pretty minor. But it does have user facing impact (right now this warning shows up in notebook in red) so might be good include this here.
sfc-gh-nkrishna
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove warning from sort_values when sort algorithm is 'quicksort'. We still raise warning if user passed a sort algorithm explicitly like
mergesortforquicksortis default value so it doesn't make sense to raise this warning.