Skip to content

Commit

Permalink
Review Feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-jrose committed Aug 29, 2024
1 parent d7635af commit ffb9876
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/snowflake/snowpark/_internal/analyzer/analyzer_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,7 @@ def create_table_statement(
}

if iceberg_config is not None:
iceberg_config = {k.lower(): v for k, v in iceberg_config.items()}
options.update(
{
EXTERNAL_VOLUME: iceberg_config.get("external_volume", None),
Expand Down Expand Up @@ -896,6 +897,7 @@ def create_table_as_select_statement(
CHANGE_TRACKING: change_tracking,
}
if iceberg_config is not None:
iceberg_config = {k.lower(): v for k, v in iceberg_config.items()}
options.update(
{
EXTERNAL_VOLUME: iceberg_config.get("external_volume", None),
Expand Down
4 changes: 2 additions & 2 deletions tests/integ/scala/test_dataframe_copy_into.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,8 @@ def test_copy_into_csv_iceberg(
test_table_name,
iceberg_config={
"external_volume": "PYTHON_CONNECTOR_ICEBERG_EXVOL",
"catalog": "SNOWFLAKE",
"base_location": "snowpark_python_tests",
"CATALOG": "SNOWFLAKE",
"BASE_LOCATION": "snowpark_python_tests",
},
)
try:
Expand Down

0 comments on commit ffb9876

Please sign in to comment.