Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-stan committed Jun 12, 2024
1 parent be76ae6 commit f488c48
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
- Fixed a bug in convert_timezone that made the setting the source_timezone parameter return an error.
- Fixed a bug where creating DataFrame with empty data of type `DateType` raises `AttributeError`.
- Fixed a bug that table merge fails when update clause exists but no update takes place.
- Fixed a bug in mock implementation of `to_char` that raises `IndexError` when incoming column has inconsecutive row index.
- Fixed a bug in handling of `CaseExpr` expressions that raises `IndexError` when incoming column has inconsecutive row index.
- Fixed a bug in implementation of `Column.like` that raises `IndexError` when incoming column has inconsecutive row index.
- Fixed a bug in mock implementation of `to_char` that raises `IndexError` when incoming column has nonconsecutive row index.
- Fixed a bug in handling of `CaseExpr` expressions that raises `IndexError` when incoming column has nonconsecutive row index.
- Fixed a bug in implementation of `Column.like` that raises `IndexError` when incoming column has nonconsecutive row index.

### Snowpark pandas API Updates

Expand Down
2 changes: 1 addition & 1 deletion tests/mock/test_column.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def test_casewhen_with_non_zero_row_index(session):
).collect() == [Row(A=7)]


def test_regexp_with_non_zero_row_index(session):
def test_like_with_non_zero_row_index(session):
df = session.create_dataframe([["1", 2], ["3", 4]], schema=["a", "b"])
assert df.filter(col("b") > 2).select(
col("a").like("1").alias("res")
Expand Down

0 comments on commit f488c48

Please sign in to comment.