Skip to content

Commit

Permalink
SNOW-1842532 Post-merge artifact removal (#2697)
Browse files Browse the repository at this point in the history
1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.
   Fixes SNOW-1842532

2. Fill out the following pre-review checklist:

- [ ] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development)

3. Please describe how your code solves the related issue.

Removed an unnecessary comment, removed the example from the docstring
of `auto_clean_up_temp_table_enabled` which was a merge artifact. See
https://github.com/snowflakedb/snowpark-python/pull/2457/files.
  • Loading branch information
sfc-gh-vbudati authored Dec 3, 2024
1 parent 2a45e4b commit ed5c17f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
4 changes: 0 additions & 4 deletions src/snowflake/snowpark/_internal/proto/update-from-devvm.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
#!/usr/bin/env bash
# This is a little helper script to build the python protobuf file and copy it over to this directory.
# If not pulling from the devvm, please provide the SSH Host as an argument.
# Cloud workspace ssh is set up via ~/.local/share/sfcli/ssh_config (or simply provide your workspace ID)
# For this script to succeed with the DevVM, you need to configure the SSH devvm host according to
# https://snowflakecomputing.atlassian.net/wiki/spaces/EN/pages/3019015180/DevVM+Troubleshooting#Symptom:-Need-to-ssh-into-the-certified-DevVM
# I.e., add the following lines to ~/.ssh/config
# Host devvm
# HostName sdp-devvm-<ldap user>
# Example usage from the repo root to pull from the devvm
Expand Down
22 changes: 0 additions & 22 deletions src/snowflake/snowpark/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -818,28 +818,6 @@ def auto_clean_up_temp_table_enabled(self) -> bool:
:meth:`DataFrame.cache_result` in the current session when the DataFrame is no longer referenced (i.e., gets garbage collected).
The default value is ``False``.
Example::
>>> import gc
>>>
>>> def f(session: Session) -> str:
... df = session.create_dataframe(
... [[1, 2], [3, 4]], schema=["a", "b"]
... ).cache_result()
... return df.table_name
...
>>> session.auto_clean_up_temp_table_enabled = True
>>> table_name = f(session)
>>> assert table_name
>>> gc.collect() # doctest: +SKIP
>>>
>>> # The temporary table created by cache_result will be dropped when the DataFrame is no longer referenced
>>> # outside the function
>>> session.sql(f"show tables like '{table_name}'").count()
0
>>> session.auto_clean_up_temp_table_enabled = False
Note:
Temporary tables will only be dropped if this parameter is enabled during garbage collection.
If a temporary table is no longer referenced when the parameter is on, it will be dropped during garbage collection.
Expand Down

0 comments on commit ed5c17f

Please sign in to comment.