Skip to content

Commit

Permalink
resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-azhan committed Aug 27, 2024
1 parent 6fe524b commit 9851ed4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
#### New Features

- Added limited support for the `Timedelta` type, including
- supporting tracking the Timedelta type through `copy`, `cache_result`, `shift`, `sort_index`, `fillna`, `diff`, `duplicated`, `empty`, `insert`, `isin`, `isna`, `items`, `iterrows`, `join`, `len`, `melt`, `nlargest`, `nsmallest`.
- supporting tracking the Timedelta type through `copy`, `cache_result`, `shift`, `sort_index`, `assign`, `bfill`, `ffill`, `fillna`, `compare`, `diff`, `drop`, `dropna`, `duplicated`, `empty`, `insert`, `isin`, `isna`, `items`, `iterrows`, `join`, `len`, `melt`, `merge`, `nlargest`, `nsmallest`.
- converting non-timedelta to timedelta via `astype`.
- `NotImplementedError` will be raised for the rest of methods that do not support `Timedelta`.
- support for subtracting two timestamps to get a Timedelta.
Expand Down
12 changes: 10 additions & 2 deletions tests/integ/modin/frame/test_equals.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,16 @@
([1, 2, None], [1, 2, None], True), # nulls are considered equal
([1, 2, 3], [1.0, 2.0, 3.0], False), # float and integer types are not equal
([1, 2, 3], ["1", "2", "3"], False), # integer and string types are not equal
# TODO(SNOW-1637101, SNOW-1637102): Support these cases.
# ([1, 2, 3], pandas.timedelta_range(1, periods=3), False), # timedelta and integer types are not equal
pytest.param(
[1, 2, 3],
pandas.timedelta_range(1, periods=3),
False, # timedelta and integer types are not equal
marks=pytest.mark.xfail(
strict=True,
raises=NotImplementedError,
reason="TODO(SNOW-1637101, SNOW-1637102): Support these cases.",
),
),
],
)
@sql_count_checker(query_count=2, join_count=2)
Expand Down

0 comments on commit 9851ed4

Please sign in to comment.