Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Naren Krishna <[email protected]>
  • Loading branch information
sfc-gh-nkrishna committed Sep 3, 2024
1 parent bd0c592 commit 798c932
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@
#### Improvements

- Refactored `quoted_identifier_to_snowflake_type` to avoid making metadata queries if the types have been cached locally.
- Improved `pd.to_datetime` to handle all local input cases.
- Refactored `resample.fillna` implementation to use ASOF Join.
- Improved `pd.to_datetime` to handle all local input cases.

#### Bug Fixes

Expand Down
10 changes: 5 additions & 5 deletions src/snowflake/snowpark/modin/plugin/_internal/resample_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -672,20 +672,20 @@ def perform_asof_join_on_frame(
# 2023-01-07 02:00:00 NaN
# 2023-01-10 00:00:00 6

interval_start_snowflake_quoted_identifier = (
get_snowflake_quoted_identifier_for_resample_index_col(referenced_frame)
)
left_timecol_snowflake_quoted_identifier = (
get_snowflake_quoted_identifier_for_resample_index_col(preserving_frame)
)
right_timecol_snowflake_quoted_identifier = (
get_snowflake_quoted_identifier_for_resample_index_col(referenced_frame)
)
output_frame, _ = join_utils.join(
left=preserving_frame,
right=referenced_frame,
how="asof",
left_on=[left_timecol_snowflake_quoted_identifier],
right_on=[interval_start_snowflake_quoted_identifier],
right_on=[right_timecol_snowflake_quoted_identifier],
left_match_col=left_timecol_snowflake_quoted_identifier,
right_match_col=interval_start_snowflake_quoted_identifier,
right_match_col=right_timecol_snowflake_quoted_identifier,
match_comparator=(
MatchComparator.GREATER_THAN_OR_EQUAL_TO
if fill_method == "ffill"
Expand Down

0 comments on commit 798c932

Please sign in to comment.