Skip to content

Commit

Permalink
more review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-joshi committed Aug 29, 2024
1 parent 8ed458d commit 36f06f6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/snowflake/snowpark/modin/plugin/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
import modin.utils # type: ignore[import] # isort: skip # noqa: E402
import modin.pandas.series_utils # type: ignore[import] # isort: skip # noqa: E402

# TODO: https://github.com/modin-project/modin/issues/7113 and https://github.com/modin-project/modin/issues/7134
# TODO: SNOW-1643979 pull in fixes for
# https://github.com/modin-project/modin/issues/7113 and https://github.com/modin-project/modin/issues/7134
# Upstream Modin has issues with certain docstring generation edge cases, so we should use our version instead
_inherit_docstrings = snowflake.snowpark.modin.utils._inherit_docstrings

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1464,10 +1464,10 @@ def set_columns(self, new_pandas_labels: Axes) -> "SnowflakeQueryCompiler":
return SnowflakeQueryCompiler(new_internal_frame)

# TODO SNOW-837664: add more tests for df.columns
def _get_columns(self) -> native_pd.Index:
def get_columns(self) -> native_pd.Index:
return self._modin_frame.data_columns_index

columns: native_pd.Index = property(_get_columns, set_columns)
columns: native_pd.Index = property(get_columns, set_columns)

def _shift_values(
self, periods: int, axis: Union[Literal[0], Literal[1]], fill_value: Hashable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

# Do not look up certain attributes in columns or index, as they're used for some
# special purposes, like serving remote context
# TODO: SNOW-1643986 examine whether to update upstream modin to follow this
_ATTRS_NO_LOOKUP = {
"____id_pack__",
"__name__",
Expand Down

0 comments on commit 36f06f6

Please sign in to comment.