Skip to content

Commit

Permalink
SNOW-1859140: Skip Cortex apply tests for Jenkins (#2764)
Browse files Browse the repository at this point in the history
<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   <!---
   In this section, please add a Snowflake Jira issue number.

Note that if a corresponding GitHub issue exists, you should still
include
   the Snowflake Jira issue number. For example, for GitHub issue
#1400, you should
   add "SNOW-1335071" here.
    --->

   Fixes SNOW-1859140

2. Fill out the following pre-review checklist:

- [x] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development)

3. Please describe how your code solves the related issue.

   Skip Cortex function apply tests when run on Jenkins

---------

Signed-off-by: Labanya Mukhopadhyay <[email protected]>
  • Loading branch information
sfc-gh-lmukhopadhyay authored Dec 17, 2024
1 parent 0362c46 commit 342c393
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
9 changes: 9 additions & 0 deletions tests/integ/modin/test_apply_snowpark_python_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

from tests.integ.modin.utils import assert_frame_equal, assert_series_equal
from tests.integ.utils.sql_counter import sql_count_checker, SqlCounter
from tests.utils import running_on_jenkins


@sql_count_checker(query_count=4)
Expand Down Expand Up @@ -71,6 +72,10 @@ def test_apply_snowpark_python_function_not_implemented():
pd.DataFrame({"a": [1, 2, 3]}).apply(asc, args=(1, 2))


@pytest.mark.skipif(
running_on_jenkins(),
reason="TODO: SNOW-1859087 snowflake.cortex.summarize SSL error",
)
def test_apply_snowflake_cortex_summarize(session):
from snowflake.snowpark.functions import snowflake_cortex_summarize

Expand All @@ -95,6 +100,10 @@ def test_apply_snowflake_cortex_summarize(session):
assert 0 < len(summary) < len(content)


@pytest.mark.skipif(
running_on_jenkins(),
reason="TODO: SNOW-1859087 snowflake.cortex.sentiment SSL error",
)
def test_apply_snowflake_cortex_sentiment(session):
from snowflake.snowpark.functions import snowflake_cortex_sentiment

Expand Down
12 changes: 10 additions & 2 deletions tests/integ/test_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
TimestampType,
VariantType,
)
from tests.utils import TestData, Utils
from tests.utils import TestData, Utils, running_on_jenkins


def test_order(session):
Expand Down Expand Up @@ -2273,6 +2273,10 @@ def test_ln(session):
"config.getoption('local_testing_mode', default=False)",
reason="FEAT: snowflake_cortex functions not supported",
)
@pytest.mark.skipif(
running_on_jenkins(),
reason="TODO: SNOW-1859087 snowflake.cortex.summarize SSL error",
)
def test_snowflake_cortex_summarize(session):
# TODO: SNOW-1758914 snowflake.cortex.summarize error on GCP
if session.connection.host == "sfctest0.us-central1.gcp.snowflakecomputing.com":
Expand Down Expand Up @@ -2312,7 +2316,11 @@ def test_snowflake_cortex_summarize(session):
"config.getoption('local_testing_mode', default=False)",
reason="FEAT: snowflake_cortex functions not supported",
)
def test_apply_snowflake_cortex_sentiment(session):
@pytest.mark.skipif(
running_on_jenkins(),
reason="TODO: SNOW-1859087 snowflake.cortex.sentiment SSL error",
)
def test_snowflake_cortex_sentiment(session):
# TODO: SNOW-1758914 snowflake.cortex.sentiment error on GCP
if session.connection.host == "sfctest0.us-central1.gcp.snowflakecomputing.com":
return
Expand Down

0 comments on commit 342c393

Please sign in to comment.